Skip to content

clean up app._compile#5599

Merged
adhami3310 merged 2 commits into
mainfrom
clean-up-app._compile
Jul 21, 2025
Merged

clean up app._compile#5599
adhami3310 merged 2 commits into
mainfrom
clean-up-app._compile

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR performs a significant architectural cleanup by removing FastAPI dependency in favor of using Starlette directly. The key changes include:

  1. Simplifying the __call__ method in app.py by removing ThreadPoolExecutor and FastAPI-specific code
  2. Adding GLOBAL_CACHE clearing after compilation to improve memory efficiency
  3. Updating dependency requirements in pyproject.toml to use Starlette >=0.47.0 instead of FastAPI

The changes are part of a larger effort to streamline the framework by removing unnecessary layers and improving memory efficiency. The removal of FastAPI indicates that the project only needs Starlette's core ASGI functionality, making the codebase leaner and more focused.

Confidence score: 4/5

  1. This PR is generally safe to merge as it simplifies rather than adds complexity
  2. High score given because the changes are well-focused on removing unnecessary code and dependencies
  3. Files needing attention:
    • app.py: Verify that all FastAPI functionality has been properly replaced
    • Integration tests: Ensure ASGI functionality remains intact

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 18, 2025

CodSpeed Performance Report

Merging #5599 will not alter performance

Comparing clean-up-app._compile (7a224a4) with main (9114d21)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit 1acdbb4 into main Jul 21, 2025
41 checks passed
@adhami3310 adhami3310 deleted the clean-up-app._compile branch July 21, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants